Add OpenAi Chat and Embedding Options #277
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tzolov
force-pushed
the
openai-chat-options-2
branch
2 times, most recently
from
0947fcc to
048a153
Compare
- Add OpenAiChatOptions that implements ChatOptions and exposes all OpenAi request options, except messages and stream. - Add OpenAiChatOptions field (as defaultOptions) to OpenAiChatClient. Implement star-up/runtime options merging on chat request creation - Add OpenAiChatOptions options field to OpenAiChatProperties. Later is set as OpenAiChatClient#defaultOptions. Use the spring.ai.openai.chat.options.* prefix to set the options. - Add tests for properties and options merging. Part of spring-projects#228
- Add OpenAiEmbeddingOptions class implementing the EmbeddingOptions interface. - Add OpenAiEmbeddingClient#defaultOptions - Add request merging with default and propmt options. - Add OopenAiEmbeddingProperties#options field of type OpenAiEmbeddingOptions
tzolov
force-pushed
the
openai-chat-options-2
branch
from
eb2f583 to
09cc4fd
Compare
tzolov
changed the title
tzolov
changed the title
markpollack
reviewed
Jan 29, 2024
| * @return the merged object represented by the given class. | ||
| */ | ||
| public static <T> T merge(Object source, Object target, Class<T> clazz) { | ||
| public static <T> T merge(Object source, Object target, Class<T> clazz, List<String> acceptedFieldNames) { |
There was a problem hiding this comment.
It seems that this list can be derived from clazz
e.g.
if (this.defaultOptions != null) {
request = ModelOptionsUtils.merge(request, this.defaultOptions, ChatCompletionRequest.class,
REQUEST_JSON_FIELD_NAMES);
}
and
private static final List<String> REQUEST_JSON_FIELD_NAMES = ModelOptionsUtils
.getJsonPropertyValues(ChatCompletionRequest.class);
|
merged in 5b4784f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OpenAiChatOptions
Add OpenAiEmbeddingOptions
Part of #228